-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gen reg tests #689
base: main
Are you sure you want to change the base?
Add gen reg tests #689
Conversation
@gpucce do you have any idea what might be causing it? what's the symptom and by how much is it 'off'? there are numerical changes across versions of pytorch, etc so some difference is expected |
@rwightman I have been keeping testing and I believe it might be just be me still doing smth wrong with github ci and not a real issue. When I run small tests locally it seems that everything is perfectly equal. I will keep trying to see if I manage to get the whole thing working. |
@gpucce have you run same random inputs through the different towers, save results to verify closeness within some float eps on same env but with current main and previous release? ie something along these lines
|
@rwightman yeah, everything I do by hand seems to be fine. It's with making proper regression tests that I get errors, will check again later or tomorrow, now I must be doing smth dumb but can't find out what |
Also, not sure if this is a factor, HF generate functionality might have
changed slightly over transformers versions in a way that impacted how it
was being used here...
…On Sun, Oct 22, 2023, 9:33 AM Giovanni Puccetti ***@***.***> wrote:
@gpucce <https://github.com/gpucce> have you run same random inputs
through the different towers, save results to verify closeness within some
float eps on same env but with current main and previous release?
ie something along these lines
torch.manual_seed(0)
img = torch.randn(16, 3, 224, 224)
text = torch.randint(0, vocab_size, (16, 77))
outputs = model(img, text)
torch.save(outputs)
...
@rwightman <https://github.com/rwightman> yeah, everything I do by hand
seems to be fine. It's with making proper regression tests that I get
errors, will check again later or tomorrow, now I must be doing smth dumb
but can't find out what
—
Reply to this email directly, view it on GitHub
<#689 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLQICFDBOHCZOAWLPIWBADYAVDERAVCNFSM6AAAAAA6K3TFMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGEZTQMZSGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
FWIW using your cat.jpg, I get |
@rwightman I think I found it, could it be the new |
specifically |
@gpucce I'd avoid using the singleton tokenizer by calling the open_clip.tokenize(), and us factory to get one for your model. |
This adds regression tests for generative models.
@rwightman this should be almost done, however there seems to be a regression error for coca that I had not noticed