Add remaining gh actions for cm submission generation #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
arjunsuresh
reviewed
Nov 22, 2024
|
|
||
| if [[ "${{ matrix.case }}" -eq 5 || "${{ matrix.case }}" -eq 6 ]]; then | ||
| # For cases 5 and 6, exit status should be 0 if cm command fails, 1 if it succeeds | ||
| if [[ $exit_status -ne 0 ]]; then |
There was a problem hiding this comment.
How's exit_status populated?
arjunsuresh
reviewed
Nov 22, 2024
| eval cm ${{ matrix.action }} script --tags=generate,inference,submission --adr.submission-checker-src.tags=_branch.dev --clean --preprocess_submission=yes --results_dir=$PWD/submission_generation_tests/${{ matrix.case }}/ --run-checker --submitter=MLCommons --tar=yes --env.CM_TAR_OUTFILE=submission.tar.gz --division=${{ matrix.division }} --env.CM_DETERMINE_MEMORY_CONFIGURATION=yes --quiet $extra_run_args | ||
| exit_status=$? | ||
| echo "Exit status for the job $description $exit_status" | ||
| if [[ "${{ matrix.case }}" == "case-5" || "${{ matrix.case }}" == "case-6" ]]; then |
There was a problem hiding this comment.
${{ matrix.case }} cannot be put inside bash if. We need to explictly assign this to a bash variable
There was a problem hiding this comment.
Thanks @arjunsuresh , let me try with this lead
There was a problem hiding this comment.
Hi @arjunsuresh , but this works
There was a problem hiding this comment.
yes, I think both should work as the string is replaced by github action before it reaches bash.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.