Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the changes made in README file. #56

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Check the changes made in README file. #56

wants to merge 29 commits into from

Conversation

ArshpreetS
Copy link

Changes made

  • Created a new logo
  • Repositioned some links to a more meaningful position
  • Added new badges.
    A couple of more small changes

@ArshpreetS ArshpreetS changed the title Check the changes made in README file and confirm my PR request. Check the changes made in README file. Mar 16, 2021
@ArshpreetS ArshpreetS closed this Mar 16, 2021
@ArshpreetS ArshpreetS reopened this Mar 16, 2021
@ArshpreetS ArshpreetS mentioned this pull request Mar 16, 2021
@ArshpreetS
Copy link
Author

This pull request is in reference to the issue #46 assigned to me. @mishraaditya595 Please check and let me know your opinion on the changes made.

@mishraaditya595
Copy link
Owner

Hey @ArshpreetS, can you try to streamline the logo a bit. It looks very straining to the eyes in the dark mode. Plus, check the current readme, and try to keep the fork and star counter.

@ArshpreetS
Copy link
Author

Okay, I will work on the logo and sure I will put back the star and fork counter

@ArshpreetS
Copy link
Author

@mishraaditya595, Can you elaborate on how you want the logo to be. I am not able to understand the problem

@ArshpreetS
Copy link
Author

@mishraaditya595, can you please confirm my PR

@ArshpreetS
Copy link
Author

@mishraaditya595, Sir I have been waiting for so long. Can you please merge it, I need this PR confirmed

@mishraaditya595
Copy link
Owner

Hello @ArshpreetS, first of all, apologies for missing out on your PR for a long. Next, I don't see any significant factor behind changing the readme of my project. The current one looks good to me.

@ArshpreetS
Copy link
Author

Please check my changes, I think you'll find it better too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants