-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Settings Page #35
Conversation
Added Settings Page With: * Dark-Light Switcher with functionality * Privacy Policy and Open Source Licences options. Added colors-night.xml: * To change colors with theme
Please attach the apk file here. |
We can only attach file less than 10MB here. APK file size is around 50MB. |
https://forms.gle/uTfMxj8282nzwPck8 |
Filled the form |
Hey @codeDamon, I think there is an issue with the bottom nav view. The icons appear black on the greyish background which it should not. They were white. Also, some new commits have been made. Make sure your fork is updated. |
It happen when app is in Light mode. For Dark mode its fine.
I haven't disturbed any other part of the code, except needed for this issue. Moreover there are no color theming for any pages, like in fragment_home.xml its background is black. We have to change these colors to dynamic colors (based on current theme of the app) |
If you want you can create an issue to Change colors of the complete app to fit light/dark mode. |
Sounds good to me. I will increase the level of the PR. |
Please create another issue for that work. I will complete that within 1 day. |
Check if the work falls under the embargo of issue #10. |
I recommend you to start working on that. I will merge this PR in a day or two as currently, I am working on fixing some core bugs of the app. Will merge it once that is sorted. |
Okay, I have started :D |
Issue #12 Solved
Added Settings Page
With:
Added colors-night.xml:
Screenshots
Updated