Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Settings Page #35

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Added Settings Page #35

merged 2 commits into from
Jan 29, 2021

Conversation

codeDamon
Copy link
Contributor

Issue #12 Solved

Added Settings Page
With:

  • Dark-Light Switcher with functionality
  • Privacy Policy and Open Source Licences options.

Added colors-night.xml:

  • To change colors with theme

Screenshots

Screenshot_demo
Updated

Added Settings Page
With:
  * Dark-Light Switcher with functionality
  * Privacy Policy and Open Source Licences options.

Added colors-night.xml:
  * To change colors with theme
@mishraaditya595
Copy link
Owner

Please attach the apk file here.

@codeDamon
Copy link
Contributor Author

We can only attach file less than 10MB here. APK file size is around 50MB.

@mishraaditya595
Copy link
Owner

https://forms.gle/uTfMxj8282nzwPck8
Try this link

@codeDamon
Copy link
Contributor Author

https://forms.gle/uTfMxj8282nzwPck8
Try this link

Filled the form

@mishraaditya595
Copy link
Owner

mishraaditya595 commented Jan 27, 2021

Hey @codeDamon, I think there is an issue with the bottom nav view. The icons appear black on the greyish background which it should not. They were white. Also, some new commits have been made. Make sure your fork is updated.

@codeDamon
Copy link
Contributor Author

Hey @codeDamon, I think there is an issue with the bottom nav view. The icons appear black on the greyish background which it should not. They were white.

It happen when app is in Light mode. For Dark mode its fine.
The reason for this:

  • BottomNavigationView has background color as grey.
  • Ideally when switching to Light mode, BottomNavigationView should have white background and black icons and in dark mode it should be grey with white icons.

I haven't disturbed any other part of the code, except needed for this issue. Moreover there are no color theming for any pages, like in fragment_home.xml its background is black. We have to change these colors to dynamic colors (based on current theme of the app)

@codeDamon
Copy link
Contributor Author

If you want you can create an issue to Change colors of the complete app to fit light/dark mode.
I can work on that issue.

@mishraaditya595
Copy link
Owner

If you want you can create an issue to Change colors of the complete app to fit light/dark mode.
I can work on that issue.

Sounds good to me. I will increase the level of the PR.

@codeDamon
Copy link
Contributor Author

codeDamon commented Jan 27, 2021

Please create another issue for that work. I will complete that within 1 day.

@mishraaditya595
Copy link
Owner

Please create another issue for that work. I will complete that within 1 day.

Check if the work falls under the embargo of issue #10.

@codeDamon
Copy link
Contributor Author

Issue #10 is a broader issue compared to adding light/dark support theme throughout the app. If you want I can work on that as well.
Please merge this pull request and then I start working on issue #10 . It hardly take a day to solve this.

@mishraaditya595
Copy link
Owner

I recommend you to start working on that. I will merge this PR in a day or two as currently, I am working on fixing some core bugs of the app. Will merge it once that is sorted.

@codeDamon
Copy link
Contributor Author

codeDamon commented Jan 27, 2021

Okay, I have started :D

@codeDamon codeDamon mentioned this pull request Jan 29, 2021
13 tasks
@mishraaditya595 mishraaditya595 merged commit ee01a86 into mishraaditya595:master Jan 29, 2021
@mishraaditya595 mishraaditya595 added DWOC Issue for DevScript Winter Of Code Level 4 labels Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DWOC Issue for DevScript Winter Of Code Level 4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants