Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added configuration options via Environment #333

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

Nold360
Copy link
Contributor

@Nold360 Nold360 commented Sep 17, 2023

Here are more additions for containers (mostly):

This change adds 3 Environment Variables:

ENV MT_CONFIG_PATH "/bin/mapserver.json"
ENV MT_LOGLEVEL "INFO"
ENV MT_READONLY "false"

MT_CONFIG_PATH allows to specify the exact location for the config.
MT_READONLY has been introduced because i used a k8s configmap for my configuration. Making it Read-Only.

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Sep 18, 2023
@BuckarooBanzay BuckarooBanzay merged commit 69b963e into minetest-mapserver:master Sep 18, 2023
3 checks passed
@BuckarooBanzay
Copy link
Member

out of curiosity: how do you deploy the mapserver to k8s, do you use tags/releases or are you using the latest tag?

@BuckarooBanzay
Copy link
Member

fyi: had to adjust the default mapserver.json location to the current dir: 073647a (without /bin prefix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants