Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type annotation in Hits and docs in Collection #2387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: type annotation in Hits and docs in Collection #2387

wants to merge 1 commit into from
+3 −3

Conversation

jiangyinzuo
Copy link

No description provided.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiangyinzuo
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link

Welcome @jiangyinzuo! It looks like this is your first PR to milvus-io/pymilvus 🎉

@mergify mergify bot added the dco-passed label Nov 28, 2024
@jiangyinzuo
fix: type annotation in Hits and docs in Collection
9d947ee 
Signed-off-by: Yinzuo Jiang <[email protected]>
Signed-off-by: Yinzuo Jiang <[email protected]>
jiangyinzuo
jiangyinzuo commented Nov 28, 2024
View reviewed changes
pymilvus/client/abstract.py
@@ -652,7 +652,7 @@ class Hits(list):
def __init__(
self,
topk: int,
pks: Union[int, str],
pks: List[Union[int, str]],
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.ids is List[Union[str, int]], so pks should be List[Union[str, int]] too.

pymilvus/orm/collection.py
@@ -700,7 +700,7 @@ def search(

partition_names (``List[str]``, optional): The names of partitions to search on.
output_fields (``List[str]``, optional):
The name of fields to return in the search result. Can only get scalar fields.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output_fields can be vector fields too, see examples/orm/hello_milvus.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@longjiquan longjiquan Awaiting requested review from longjiquan

Assignees
No one assigned
Labels
dco-passed size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiangyinzuo @sre-ci-robot