Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [skip e2e]2.4 update workflow macos to 13 #37942

Merged
merged 1 commit into from
Nov 22, 2024
Merged

enhance: [skip e2e]2.4 update workflow macos to 13 #37942

merged 1 commit into from
Nov 22, 2024

Conversation

zhikunyao
Copy link
Collaborator

No description provided.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 22, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Nov 22, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 22, 2024

@zhikunyao Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Nov 22, 2024
@zhikunyao
Copy link
Collaborator Author

/assign @yellow-shine

@yellow-shine
Copy link
Collaborator

/lgtm

@zhikunyao zhikunyao changed the title enhance: 2.4 update workflow macos to 13 enhance: [skip e2e]2.4 update workflow macos to 13 Nov 22, 2024
@mergify mergify bot added the ci-passed label Nov 22, 2024
@zhikunyao
Copy link
Collaborator Author

/kind improvment

@sre-ci-robot
Copy link
Contributor

@zhikunyao: The label(s) kind/improvment cannot be applied, because the repository doesn't have them.

In response to this:

/kind improvment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LoveEachDay
LoveEachDay approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@LoveEachDay LoveEachDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yanliang567
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LoveEachDay, yanliang567, zhikunyao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit cf1c423 into milvus-io:2.4 Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoveEachDay LoveEachDay LoveEachDay approved these changes

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@LoveEachDay LoveEachDay

@yellow-shine yellow-shine

Labels
approved ci-passed dco-passed DCO check passed. kind/branch-feature kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhikunyao @yellow-shine @sre-ci-robot @yanliang567 @LoveEachDay