Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Channel may be released after balance (#37862) #37940

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from

Conversation

weiliu1031
Copy link
Contributor

issue: #37830
pr: #37862
casue dist handler doesn't set channel's version, so if channel checker try to dedup channel, it may release the new delegator after balance finished.

this PR fix the way to set proper version for channel.

issue: milvus-io#37830
casue dist handler doesn't set channel's version, so if channel checker
try to dedup channel, it may release the new delegator after balance
finished.

this PR fix the way to set proper version for channel.

Signed-off-by: Wei Liu <[email protected]>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 22, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.67%. Comparing base (fc96133) to head (d421c4f).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37940      +/-   ##
==========================================
+ Coverage   80.62%   83.67%   +3.05%     
==========================================
  Files        1069      801     -268     
  Lines      166979   140519   -26460     
==========================================
- Hits       134621   117579   -17042     
+ Misses      27946    18524    -9422     
- Partials     4412     4416       +4     
Files with missing lines Coverage Δ
internal/querycoordv2/dist/dist_handler.go 96.01% <100.00%> (+0.07%) ⬆️

... and 300 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants