Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: set the maximum database configuration to be refreshable #37931

Merged

Conversation

jaime0815
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (b48f531) to head (bc1cd95).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37931       +/-   ##
===========================================
+ Coverage   68.87%   81.03%   +12.15%     
===========================================
  Files         289     1358     +1069     
  Lines       25481   190438   +164957     
===========================================
+ Hits        17551   154326   +136775     
- Misses       7930    30636    +22706     
- Partials        0     5476     +5476     
Components Coverage Δ
Client 72.16% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.21% <ø> (∅)
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.35% <ø> (ø)

... and 1068 files with indirect coverage changes

---- 🚨 Try these New Features:

@mergify mergify bot added the ci-passed label Nov 22, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 22, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 8187fb7 into milvus-io:master Nov 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants