Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: error msg #37901

Merged
merged 1 commit into from
Nov 22, 2024
Merged

enhance: error msg #37901

merged 1 commit into from
Nov 22, 2024

Conversation

smellthemoon
Copy link
Contributor

Signed-off-by: lixinguo <[email protected]>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 21, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (b3fc530) to head (299d1bb).
Report is 40 commits behind head on master.

Files with missing lines Patch % Lines
internal/distributed/proxy/httpserver/utils.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37901      +/-   ##
==========================================
+ Coverage   81.00%   81.03%   +0.02%     
==========================================
  Files        1357     1357              
  Lines      190018   190144     +126     
==========================================
+ Hits       153922   154076     +154     
+ Misses      30625    30595      -30     
- Partials     5471     5473       +2     
Components Coverage Δ
Client 72.16% <ø> (ø)
Core 68.89% <ø> (+0.01%) ⬆️
Go 83.20% <0.00%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/distributed/proxy/httpserver/utils.go 84.22% <0.00%> (ø)

... and 56 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

mergify bot commented Nov 21, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 22, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit df08d91 into milvus-io:master Nov 22, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants