Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [24]Replace outer lock with concurrent map (#37817) #37897

Open
wants to merge 2 commits into
base: 2.4
Choose a base branch
from

Conversation

XuanYang-cn
Copy link
Contributor

See also: #37493
pr: #37817

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 21, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XuanYang-cn
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 21, 2024
Copy link
Contributor

mergify bot commented Nov 21, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: yangxuan <[email protected]>
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.57%. Comparing base (4aca68a) to head (53f2d80).
Report is 1 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datanode/writebuffer/manager.go 91.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37897      +/-   ##
==========================================
+ Coverage   72.24%   80.57%   +8.33%     
==========================================
  Files        1069     1069              
  Lines      166979   166946      -33     
==========================================
+ Hits       120641   134525   +13884     
+ Misses      41919    27995   -13924     
- Partials     4419     4426       +7     
Files with missing lines Coverage Δ
internal/datanode/writebuffer/write_buffer.go 75.96% <100.00%> (-0.90%) ⬇️
internal/datanode/writebuffer/manager.go 93.15% <91.66%> (+0.57%) ⬆️

... and 231 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants