Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "enhance: [2.4] Enable RemoteLoad l0 forward policy" #37875

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

czs007
Copy link
Collaborator

@czs007 czs007 commented Nov 21, 2024

issue #35303
pr: #37867
This reverts commit cdf703a.

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. approved labels Nov 21, 2024
Copy link
Contributor

mergify bot commented Nov 21, 2024

@czs007 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Nov 21, 2024
Copy link
Contributor

mergify bot commented Nov 21, 2024

@czs007 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Nov 21, 2024
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. do-not-merge/missing-related-pr labels Nov 21, 2024
@yanliang567 yanliang567 added this to the 2.4.17 milestone Nov 22, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.71%. Comparing base (e63a2f3) to head (a508067).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37875      +/-   ##
==========================================
+ Coverage   79.70%   83.71%   +4.01%     
==========================================
  Files        1069      801     -268     
  Lines      166979   140515   -26464     
==========================================
- Hits       133092   117637   -15455     
+ Misses      29490    18472   -11018     
- Partials     4397     4406       +9     
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.35% <100.00%> (ø)

... and 300 files with indirect coverage changes

---- 🚨 Try these New Features:

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 22, 2024
@sre-ci-robot sre-ci-robot merged commit 9b3de3a into milvus-io:2.4 Nov 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants