Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: remove the collectionBasicInfo class in the proxy metacache #37874

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Nov 21, 2024

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/M Denotes a PR that changes 30-99 lines. labels Nov 21, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 21, 2024
Copy link
Contributor

mergify bot commented Nov 21, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 21, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 21, 2024

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 21, 2024

rerun cpp-unit-test

@SimFG
Copy link
Contributor Author

SimFG commented Nov 21, 2024

rerun ut

1 similar comment
@SimFG
Copy link
Contributor Author

SimFG commented Nov 21, 2024

rerun ut

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (923a661) to head (b3ea4ec).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37874      +/-   ##
==========================================
- Coverage   82.91%   81.05%   -1.86%     
==========================================
  Files        1069     1358     +289     
  Lines      164955   190425   +25470     
==========================================
+ Hits       136767   154348   +17581     
- Misses      22710    30591    +7881     
- Partials     5478     5486       +8     
Components Coverage Δ
Client 72.16% <ø> (ø)
Core 68.87% <ø> (∅)
Go 83.23% <100.00%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/meta_cache.go 90.39% <100.00%> (-0.13%) ⬇️

... and 319 files with indirect coverage changes

---- 🚨 Try these New Features:

@mergify mergify bot added the ci-passed label Nov 21, 2024
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Nov 22, 2024
@chyezh
Copy link
Contributor

chyezh commented Nov 22, 2024

/lgtm

Copy link
Contributor

mergify bot commented Nov 22, 2024

@SimFG Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@czs007
Copy link
Collaborator

czs007 commented Nov 22, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Nov 22, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 22, 2024

rerun go-sdk

@mergify mergify bot added the ci-passed label Nov 22, 2024
@sre-ci-robot sre-ci-robot merged commit 7c5a801 into milvus-io:master Nov 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants