Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [2.4] Reduce segmentManager lock granularity #37869

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from
Open

enhance: [2.4] Reduce segmentManager lock granularity #37869

wants to merge 1 commit into from
+279 −252

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented Nov 21, 2024 •
edited
Loading

Use a channel level key lock for segments in segmentManager.

issue: #37633, #37630

pr: #37836

@bigsheeper bigsheeper added the 10kcp PR related to 10k collection partitions Project label Nov 21, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Nov 21, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 21, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper bigsheeper changed the title enhance: [2.4] Optimize segmentManager segments enhance: [2.4] Reduce segmentManager lock granularity Nov 22, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 22, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@sunby sunby Awaiting requested review from sunby

Assignees
No one assigned
Labels
10kcp PR related to 10k collection partitions Project dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigsheeper @sre-ci-robot