Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [cpp-unit-test] abort previous build if it's a PR, otherwise… #37571

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

yellow-shine
Copy link
Collaborator

@yellow-shine yellow-shine commented Nov 11, 2024

[cpp-unit-test] abort previous build if it's a PR, otherwise queue the build

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 11, 2024
Copy link
Contributor

mergify bot commented Nov 11, 2024

@yellow-shine go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.13%. Comparing base (fca946d) to head (fef555f).
Report is 20 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (fca946d) and HEAD (fef555f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (fca946d) HEAD (fef555f)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37571       +/-   ##
===========================================
- Coverage   80.58%   68.13%   -12.46%     
===========================================
  Files        1356      290     -1066     
  Lines      190009    25395   -164614     
===========================================
- Hits       153117    17302   -135815     
+ Misses      31485     8093    -23392     
+ Partials     5407        0     -5407     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.13% <ø> (ø)
Go ∅ <ø> (∅)

see 1066 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 11, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yellow-shine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit cef5b7f into milvus-io:master Nov 12, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants