Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Enable to add router from proxy to replica #35851

Closed
wants to merge 3 commits into from

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Aug 30, 2024

issue: #35859
pr: #35942
if milvus has multi replica and multi proxy, in case of each proxy access all replicas, we can add router from proxy to replica, which means assign replicas to all proxy, each proxy got same number of replicas, then only access those replicas.

Notice when the goal of evenly assign all replicas to proxies can't be achieved, fallback to share all replicas between proxies.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Aug 30, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Aug 30, 2024
Copy link
Contributor

mergify bot commented Aug 30, 2024

@weiliu1031 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Aug 30, 2024
Copy link
Contributor

mergify bot commented Aug 30, 2024

@weiliu1031 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

if milvus has multi replica and multi proxy, in case of each proxy
access all replicas, we can add router from proxy to replica, which
means assign replicas to all proxy, each proxy got same number of
replicas, then only access those replicas.

Notice when the goal of evenly assign all replicas to proxies can't be
achieved, fallback to share all replicas between proxies.

Signed-off-by: Wei Liu <[email protected]>
Copy link
Contributor

mergify bot commented Sep 3, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
Copy link

stale bot commented Oct 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Oct 5, 2024
@stale stale bot closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement sig/testing size/L Denotes a PR that changes 100-499 lines. stale indicates no udpates for 30 days test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants