enhance: Enable to add router from proxy to replica #35942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sre-ci-robot
added
area/test
sig/testing
test/integration
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weiliu1031 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
if milvus has multi replica and multi proxy, in case of each proxy access all replicas, we can add router from proxy to replica, which means assign replicas to all proxy, each proxy got same number of replicas, then only access those replicas. Notice when the goal of evenly assign all replicas to proxies can't be achieved, fallback to share all replicas between proxies. Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
weiliu1031
force-pushed
the
assign_replica_master
branch
from
3397fb8
to
743e2ae
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #35859
if milvus has multi replica and multi proxy, in case of each proxy access all replicas, we can add router from proxy to replica, which means assign replicas to all proxy, each proxy got same number of replicas, then only access those replicas.
Notice when the goal of evenly assign all replicas to proxies can't be achieved, fallback to share all replicas between proxies.