fix: [Cherry-pick] deduce AutoID from field info (#656)

cherry pick from master pr: #655 Resolves: #654 --------- Signed-off-by: Congqi Xia <[email protected]>
milvus-io · Jan 17, 2024 · 01a80f0 · 01a80f0
1 parent 5ed4388
commit 01a80f0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/entity/schema.go b/entity/schema.go
@@ -107,11 +107,13 @@ func (s *Schema) ProtoMessage() *schema.CollectionSchema {
 
 // ReadProto parses proto Collection Schema
 func (s *Schema) ReadProto(p *schema.CollectionSchema) *Schema {
-	s.AutoID = p.GetAutoID()
 	s.Description = p.GetDescription()
 	s.CollectionName = p.GetName()
 	s.Fields = make([]*Field, 0, len(p.GetFields()))
 	for _, fp := range p.GetFields() {
+		if fp.GetAutoID() {
+			s.AutoID = true
+		}
 		s.Fields = append(s.Fields, NewField().ReadProto(fp))
 	}
 	s.EnableDynamicField = p.GetEnableDynamicField()

diff --git a/entity/schema_test.go b/entity/schema_test.go
@@ -107,7 +107,6 @@ func (s *SchemaSuite) TestBasic() {
 			nsch = nsch.ReadProto(p)
 
 			s.Equal(sch.CollectionName, nsch.CollectionName)
-			s.Equal(sch.AutoID, nsch.AutoID)
 			s.Equal(sch.Description, nsch.Description)
 			s.Equal(sch.EnableDynamicField, nsch.EnableDynamicField)
 			s.Equal(len(sch.Fields), len(nsch.Fields))

diff --git a/test/testcases/collection_test.go b/test/testcases/collection_test.go
@@ -419,7 +419,7 @@ func TestCreateJsonCollection(t *testing.T) {
 
 	// schema
 	collName := common.GenRandomString(6)
-	schema := common.GenSchema(collName, false, fields)
+	schema := common.GenSchema(collName, true, fields)
 
 	// create collection
 	err := mc.CreateCollection(ctx, schema, common.DefaultShards)