Merge pull request #1160 from sharifhh/patch-1

Do not throw error if event is not http (http-cors)
middyjs · Jan 11, 2024 · ad47810 · ad47810
2 parents 432855f + c72d287
commit ad47810
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/packages/http-cors/__tests__/index.js b/packages/http-cors/__tests__/index.js
@@ -819,15 +819,11 @@ test('it should set Vary header if present in config', async (t) => {
   })
 })
 
-test('it should throw when not a http event', async (t) => {
+test('it should not throw when not a http event', async (t) => {
   const handler = middy((event, context) => {})
 
   handler.use(cors())
 
   const event = {}
-  try {
-    await handler(event, context)
-  } catch (e) {
-    t.is(e.message, 'Unknown http event format')
-  }
+  t.notThrows(async () => await handler(event, context))
 })
diff --git a/packages/http-cors/index.js b/packages/http-cors/index.js
@@ -131,11 +131,6 @@ const modifyHeaders = (headers, options, request) => {
   const httpMethod = getVersionHttpMethod[request.event.version ?? '1.0']?.(
     request.event
   )
-  if (!httpMethod) {
-    throw new Error('Unknown http event format', {
-      cause: { package: '@middy/http-cors' }
-    })
-  }
   if (
     httpMethod === 'OPTIONS' &&
     options.cacheControl &&