fix: headers[headerName].trim is not a function

fixes: #1097
middyjs · Sep 17, 2023 · 24a6ff2 · 24a6ff2
1 parent 50d8e89
commit 24a6ff2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/packages/s3/index.js b/packages/s3/index.js
@@ -32,15 +32,10 @@ const s3Middleware = (opts = {}) => {
     for (const internalKey of Object.keys(options.fetchData)) {
       if (cachedValues[internalKey]) continue
       values[internalKey] = client
-        .send(
-          new GetObjectCommand({
-            ...options.fetchData[internalKey],
-            ChecksumMode: true
-          })
-        )
+        .send(new GetObjectCommand(options.fetchData[internalKey]))
         .then(async (resp) => {
           let value = await resp.Body.transformToString()
-          if (contentTypePattern.test(resp.headers.ContentType)) {
+          if (contentTypePattern.test(resp.ContentType)) {
             value = jsonSafeParse(value)
           }
           return value

diff --git a/website/docs/middlewares/s3.md b/website/docs/middlewares/s3.md
@@ -34,9 +34,10 @@ NOTES:
 
 ```javascript
 import middy from '@middy/core'
-import appConfig from '@middy/s3'
+import s3 from '@middy/s3'
 
 const handler = middy((event, context) => {
+  console.log(context.config)
   const response = {
     statusCode: 200,
     headers: {},
@@ -53,7 +54,8 @@ handler.use(
         Bucket: '...',
         Key: '...'
       }
-    }
+    },
+    setToContext: true
   })
 )
 ```