Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version selection button in docs #1144

Merged
merged 4 commits into from
Feb 26, 2023
Merged

Fix version selection button in docs #1144

merged 4 commits into from
Feb 26, 2023

Conversation

adamjstewart
Copy link
Collaborator

Want to see if this fixes the broken version selection button.

@github-actions github-actions bot added the dependencies Packaging and dependencies label Feb 24, 2023
@adamjstewart
Copy link
Collaborator Author

Okay, 5.3.0 works, let's try 6.0.0 to confirm that that's the version that broken pytorch-sphinx-theme.

@adamjstewart
Copy link
Collaborator Author

And 6.0.0 breaks, will open an issue.

@adamjstewart
Copy link
Collaborator Author

@adamjstewart adamjstewart added this to the 0.4.1 milestone Feb 24, 2023
@adamjstewart
Copy link
Collaborator Author

We may want to reconsider switching to trojanzoo_sphinx_theme since it seems to actually be supported.

@adamjstewart adamjstewart marked this pull request as ready for review February 24, 2023 15:05
@calebrob6
Copy link
Member

This also fixes the floating menus (these break with the version selector)

@calebrob6 calebrob6 merged commit 692a45a into main Feb 26, 2023
@calebrob6 calebrob6 deleted the docs/sphinx branch February 26, 2023 16:36
calebrob6 pushed a commit that referenced this pull request Apr 10, 2023
* Fix version selection button in docs

* Try 6.0.0

* Require sphinx < 6

* Pin conda too
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* Fix version selection button in docs

* Try 6.0.0

* Require sphinx < 6

* Pin conda too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Packaging and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants