Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order and robustness of CTRL_*_EVENTs #18233

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Nov 21, 2024

  • This fixes a regression in 391abaf, which caused attached clients
    to receive CTRL_CLOSE_EVENTs, etc., in oldest-to-newest order,
    while historically the opposite is expected.
  • It also changes the behavior of ProcessCtrlEvents to dispatch
    these events no matter whether a client is already dead.
    This restores the Windows XP to Windows 8.1 behavior.

Both of these fixes would address the issue on their own.

Closes #15373

Validation Steps Performed

  • CloseTest from our repository shows newest-to-oldest order again.
  • node gets killed when run under npm and closing the tab.

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Interop Communication between processes Product-Terminal The new Windows Terminal. labels Nov 21, 2024
src/host/input.cpp Outdated Show resolved Hide resolved
@DHowett DHowett merged commit 09d8ac4 into main Nov 25, 2024
17 of 19 checks passed
@DHowett DHowett deleted the dev/lhecker/15373-ctrl-close-fix branch November 25, 2024 23:05
@DHowett
Copy link
Member

DHowett commented Nov 25, 2024

admin merge - arm64 vcpkg issue, remediated in main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Interop Communication between processes Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
Status: To Consider
Status: To Consider
Status: To Cherry Pick
Development

Successfully merging this pull request may close these issues.

Exiting terminal while running npm in a pane does not terminate processes from terminal
3 participants