Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: omit using gRPC for pktmon IPC on Windows #865

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

matmerr
Copy link
Member

@matmerr matmerr commented Oct 15, 2024

Description

Replace grpc stub with build files acting as stub.

Related Issue

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@matmerr matmerr marked this pull request as ready for review October 21, 2024 17:31
@matmerr matmerr requested a review from a team as a code owner October 21, 2024 17:31
Copy link

This PR will be closed in 7 days due to inactivity.

@github-actions github-actions bot added the meta/waiting-for-author Blocked and waiting on the author label Nov 21, 2024
@nddq nddq removed the meta/waiting-for-author Blocked and waiting on the author label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants