use anchor element for social links when in game #10277
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/microsoft/pxt-minecraft/issues/2668
the in-game webview on macos doesn't support any of the window open APIs that the browser provides.
<a>
elements work though, so this PR replaces the social buttons with<a>
elements.normally i would just replace these for all platforms since
<a>
elements are usually better for accessibility, but the only way to open a pop up window is with js and i think that's the expected behavior for social buttons. doesn't matter for the in-game experience given that those all open in the browser outside the game anyhow.