Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use anchor element for social links when in game #10277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Nov 19, 2024

fixes https://github.com/microsoft/pxt-minecraft/issues/2668

the in-game webview on macos doesn't support any of the window open APIs that the browser provides.<a> elements work though, so this PR replaces the social buttons with <a> elements.

normally i would just replace these for all platforms since <a> elements are usually better for accessibility, but the only way to open a pop up window is with js and i think that's the expected behavior for social buttons. doesn't matter for the in-game experience given that those all open in the browser outside the game anyhow.

@riknoll riknoll requested a review from a team November 19, 2024 22:41
@abchatra
Copy link
Collaborator

@riknoll build failing

@riknoll
Copy link
Member Author

riknoll commented Nov 19, 2024

@abchatra i'll fix it, but leave this one out of the release anyhow. i'd like more people to test it first so let's save it for the hotfix

@abchatra
Copy link
Collaborator

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants