[FF-A] ACPI TPM2 Table for FF-A Implementation: #358
Conversation
…the correct ACPI table with FF-A information. This includes the .inf, .asl. and .c files.
| SwSmiValue and allocated NVS region address. | ||
|
|
||
| Caution: This module requires additional review when modified. | ||
| This driver will have external input - variable and ACPINvs data in SMM mode. |
There was a problem hiding this comment.
This description is not true anymore.
|
|
||
| #include <Guid/TpmInstance.h> | ||
| #include <Guid/TpmNvsMm.h> | ||
| #include <Guid/PiSmmCommunicationRegionTable.h> |
| ControlArea->Response = PcdGet64 (PcdTpmBaseAddress) + 0x80; | ||
| break; | ||
| default: | ||
| DEBUG ((DEBUG_ERROR, "TPM2 InterfaceType get error! %d\n", InterfaceType)); |
There was a problem hiding this comment.
I think you want to set the return status code here?
| break; | ||
| } | ||
|
|
||
| DEBUG ((DEBUG_INFO, "Tpm2 ACPI table size %d\n", mTpm2AcpiTemplate.Header.Length)); |
There was a problem hiding this comment.
And then check the status code then bail the installation if failed?
| # populates registered SMI callback functions for Tcg2 physical presence | ||
| # and MemoryClear to handle the requests for ACPI method. It needs to be | ||
| # used together with Tcg2 MM drivers to exchange information on registered | ||
| # SwSmiValue and allocated NVS region address. |
There was a problem hiding this comment.
Same here, let's update the description.
| Tpm2CommandLib | ||
| Tcg2PhysicalPresenceLib | ||
| PcdLib | ||
| MmUnblockMemoryLib |
There was a problem hiding this comment.
Do we still need this lib? I do not think we called it anywhere?
|
|
||
| [Guids] | ||
| gEfiTpmDeviceInstanceTpm20DtpmGuid ## PRODUCES ## GUID # TPM device identifier | ||
| gTpmNvsMmGuid ## CONSUMES |
|
|
||
| [Protocols] | ||
| gEfiAcpiTableProtocolGuid ## CONSUMES | ||
| gEfiMmCommunicationProtocolGuid ## CONSUMES |
| gEfiMmCommunicationProtocolGuid ## CONSUMES | ||
|
|
||
| [FixedPcd] | ||
| gEfiSecurityPkgTokenSpaceGuid.PcdSmiCommandIoPort ## CONSUMES |
| // | ||
| // Operational region for TPM access | ||
| // | ||
| OperationRegion (TPMR, SystemMemory, 0x10000010000, 0x5000) |
There was a problem hiding this comment.
We can change this over to use fixed PCD now, right?
| Cacheable, | ||
| ReadWrite, | ||
| 0x0, | ||
| 0x10000010000, |
|
The change seems legit. There are a few functions looks largely alike with those in the ACPI driver. When we upstream this to EDK2, I think they will want to share these functions instead of duplicating another one. |
|
CI builds are failing, try to follow these guide to repro the failure locally: https://github.com/tianocore/tianocore.github.io/wiki/How-to-Build-With-Stuart#before-each-build-steps. There are logs published along with the pipeline builds. But it will not be efficient as the pipeline queue could be very long. |
Description
Added the TCG2 ACPI changes for FF-A enablement in order to generate the correct ACPI table with FF-A information. This includes the .inf, .asl. and .c files.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
Utilized the UEFI shell "acpiview" command to verify the TPM2 table is being populated properly.
Integration Instructions
N/A