Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHERRY-PICK] UefiCpuPkg: Remove UefiCpuLib [Rebase & FF] #546

Merged
merged 2 commits into from
Aug 31, 2023
Merged

[CHERRY-PICK] UefiCpuPkg: Remove UefiCpuLib [Rebase & FF] #546

merged 2 commits into from
Aug 31, 2023

Conversation

makubacki
Copy link
Member

@makubacki makubacki commented Aug 30, 2023 •
edited
Loading

Description

Because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib
and all modules are updated to not depend on this library,
remove it completely.

Cc: Eric Dong [email protected]
Cc: Ray Ni [email protected]
Cc: Rahul Kumar [email protected]
Signed-off-by: Yu Pu [email protected]
Reviewed-by: Ray Ni [email protected]
Signed-off-by: Zhiguang Liu [email protected]
(cherry picked from commit b991aec)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

  • mu_basecore CI

Integration Instructions

The following (cherry-picked) commits already removed functionality
from UefiCpuPkg:

This PR removes the library entirely (also cherry-picked directly). Therefore,
ensure CpuLib is used in place of UefiCpuLib in downstream packages since
functionality was converged there.

@PuYuuu @makubacki
[CHERRY-PICK] UefiCpuLib: Remove UefiCpuLib.
79a0029 
Because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib and all modules
are updated to not depend on this library, remove it completely.

Cc: Eric Dong <[email protected]>
Cc: Ray Ni <[email protected]>
Cc: Rahul Kumar <[email protected]>
Signed-off-by: Yu Pu <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
Signed-off-by: Zhiguang Liu <[email protected]>
(cherry picked from commit b991aec)
@makubacki makubacki added impact:breaking-change Requires integration attention semver:patch Pull requests that should increment the release patch version labels Aug 30, 2023
@makubacki makubacki self-assigned this Aug 30, 2023
@makubacki makubacki changed the title [CHERRY-PICK] UefiCpuLib: Remove UefiCpuLib. [CHERRY-PICK] UefiCpuPkg: Remove UefiCpuLib Aug 30, 2023
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Aug 30, 2023
@makubacki
PcAtChipsetPkg: Remove UefiCpuLib reference
d7fdfba 
The library is being removed from UefiCpuPkg with CpuLib used in
its place so remove it from the PcAtChipsetPkg DSC file.

Signed-off-by: Michael Kubacki <[email protected]>
@makubacki makubacki requested a review from os-d August 30, 2023 23:45
@makubacki makubacki removed the semver:patch Pull requests that should increment the release patch version label Aug 30, 2023
@makubacki makubacki changed the title [CHERRY-PICK] UefiCpuPkg: Remove UefiCpuLib [CHERRY-PICK] UefiCpuPkg: Remove UefiCpuLib [Rebase & FF] Aug 30, 2023
@makubacki makubacki enabled auto-merge (rebase) August 31, 2023 01:00
@makubacki makubacki merged commit 6e954fb into microsoft:release/202302 Aug 31, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srilathasridharan srilathasridharan srilathasridharan approved these changes

@kenlautner kenlautner kenlautner approved these changes

@os-d os-d os-d approved these changes

@TaylorBeebe TaylorBeebe Awaiting requested review from TaylorBeebe

Assignees

@makubacki makubacki

Labels
impact:breaking-change Requires integration attention impact:non-functional Does not have a functional impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@makubacki @os-d @kenlautner @srilathasridharan @PuYuuu