-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added normalize.css package as reset css #1071
base: features/ux
Are you sure you want to change the base?
added normalize.css package as reset css #1071
Conversation
src/web/package.json
Outdated
@@ -12,6 +12,7 @@ | |||
}, | |||
"dependencies": { | |||
"eslint-plugin-react": "^7.37.1", | |||
"normalize.css": "^8.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is necessary. Cold we just add this to the main css file?
* {
padding: 0;
margin: 0;
box-sizing: border-box;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure we can do that . I removed the package and added the reset rule in the start of index.css
My idea was to use the normalize.css that seems to add a variaty of reset rules for different browsers. But it adds to complexity and probably we dont need it atm:
https://github.com/necolas/normalize.css/blob/master/normalize.css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ivanmtta Are you suggesting that those are the only 3 rules we need? It's been a while since I've looked at resets, but I would expect a lot more to be needed than just these. Colors, sizes,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ivan and I discussed this. We agreed to revert back to normalize.css out of the box.
@akiskips You can resolve this comment when you've done that. Thanks!
π οΈ Description
Added normalize.css package from https://github.com/necolas/normalize.css/
Added import at main.tsx
Fixes #
π· Screenshots
π Checklist
π¬ How did you test this change?
πββοΈ Do any of the following that apply?
π Did you update
docs/changelog.md
?π Did you update documentation?