Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs and python-tensorboard: patched vendor tarball to fix CVE-2024-21538 #11140

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

0xba1a
Copy link
Contributor

@0xba1a 0xba1a commented Nov 19, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Fix CVE-2024-21538 by patching

Change Log
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology

@mbykhovtsev-ms mbykhovtsev-ms changed the title Fix CVE-2024-21538 by patching vendor packages Fix CVE-2024-21538 for nodejs by patching vendor packages Nov 20, 2024
@mbykhovtsev-ms mbykhovtsev-ms changed the title Fix CVE-2024-21538 for nodejs by patching vendor packages nodejs: patched vendor tarball to fix CVE-2024-21538 Nov 20, 2024
@mbykhovtsev-ms mbykhovtsev-ms changed the title nodejs: patched vendor tarball to fix CVE-2024-21538 nodejs and python-tensorboard: patched vendor tarball to fix CVE-2024-21538 Nov 20, 2024
Copy link
Contributor

@mbykhovtsev-ms mbykhovtsev-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CVE for python-tensorboard should be disputed as it is within node. Can you remove that patch and just leave the nodejs patch?

@0xba1a
Copy link
Contributor Author

0xba1a commented Nov 21, 2024

The CVE for python-tensorboard should be disputed as it is within node. Can you remove that patch and just leave the nodejs patch?

Removed the patch from python-tensorboard. Updated the spec file to remove the npm directory before building it.

@jslobodzian jslobodzian merged commit 6fa4340 into fasttrack/3.0 Nov 22, 2024
10 checks passed
@jslobodzian jslobodzian deleted the bala/fix-CVE-2024-21538-fasttrack branch November 22, 2024 20:30
CBL-Mariner-Bot pushed a commit that referenced this pull request Nov 22, 2024
@CBL-Mariner-Bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants