Add new parameter to KubeloginInstallerV0 to authorize request to github to avoid request limits on unauthorized requests #20685
+45
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: KubeloginInstallerV0
Description: This task makes requests to the GitHub API to fetch the url to download. Currently, these requests are unauthorized. However, the GitHub API has low rate limits on unauthorized requests, so these requests can fail which in turn causes the task run to fail. This PR adds a new parameter to allow the user to supply a Github Service Connection that is used to authorize these requests. Authorized requests have a much higher rate limit, thus providing authorization makes this issue much less likely to occur.
Documentation changes required: Y
Added unit tests: N
Attached related issue: (Y/N) #19097
Checklist: