-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App Configuration] Update App Configuration tasks description #20682
base: master
Are you sure you want to change the base?
Conversation
We should also update the user-agent name -
|
We should update the third party notices text
|
"helpMarkDown": "Email [email protected] for questions.", | ||
"category": "Utility", | ||
"author": "Microsoft Corporation", | ||
"version": { | ||
"Major": 10, | ||
"Minor": 247, | ||
"Minor": 249, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, how do we decide the minor version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor version is based on the current sprint version please see-> https://github.com/microsoft/azure-pipelines-tasks/blob/master/docs/taskversionbumping.md
@@ -283,7 +283,7 @@ | |||
"InvalidTagsWithSample": "Invalid format for parameter 'Tags'. Sample 'Tags': {\"name1\": \"value1\", \"name2\":, \"value2\"}.", | |||
"InvalidAppConfigurationEndpoint": "Invalid App Configuration endpoint %s. Please provide a valid App Configuration endpoint.", | |||
"InvalidTypeInTags": "Invalid type in parameter 'Tags'. Only strings supported", | |||
"AzureAppConfigurationPushTaskStartingUp": "Azure App Configuration Push Task is starting up...", | |||
"AzureAppConfigurationPushTaskStartingUp": "Azure App Configuration Import Task is starting up...", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The string name should be "AzureAppConfigurationImportTaskStartingUp"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, this has been updated, thanks
@ChristineWanjau nice catch this has been updated, thanks |
5f4a01a
to
7b6f9de
Compare
@ChristineWanjau thanks for catching this has been updated |
Task name: App Configuration Tasks [App Configuration Import task, App Configuration Export task]
Description: Update tasks description and help url
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) N
Checklist: