Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More guidance #600

Closed
wants to merge 7 commits into from
Closed

Conversation

injcristianrojas
Copy link
Contributor

No description provided.

@injcristianrojas
Copy link
Contributor Author

@microsoft-github-policy-service agree

@gfs
Copy link
Contributor

gfs commented Jan 16, 2024

@injcristianrojas Thanks for your contribution. These look like some good improvements overall to the guidance. Will just need to double check with policy folks on exact verbiage.

@gfs
Copy link
Contributor

gfs commented Feb 5, 2024

I plan to merge this this week, first need to merge #603 to resolve an issue with the pipelines.

@gfs
Copy link
Contributor

gfs commented Feb 28, 2024

Limitations on the pipeline make it tough to merge guidance only changes. Sorry for the delay here, I've incorporated your guidance improvements into #606 instead.

gfs added a commit that referenced this pull request Feb 29, 2024
* Update dependencies

* Improve Confidence Reporting

Adds Confidence Field to Issue Record
Sets Confidence to either Confidence of Pattern if specified, or confidence of overall rule if specified
Report Confidence and Severity in special Github sarif fields.
Add Confidence values to rules

* Update Guidance (#600)
Fixed typo
Tokens/keys in source code
DES->AES Guidance

* Update Changelog.md
---------

Co-authored-by: Cristián Rojas <[email protected]>
@gfs
Copy link
Contributor

gfs commented Feb 29, 2024

Included these changes in #606.

@gfs gfs closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants