Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactive Views Renderer Soy #273

Draft
wants to merge 17 commits into
base: 6.0.x
Choose a base branch
from
Draft

Reactive Views Renderer Soy #273

wants to merge 17 commits into from

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Aug 10, 2021

No description provided.

sgammon and others added 16 commits March 12, 2020 00:34
@sgammon
Feature: Reactive Soy (v2)
ba3bcc7 
This changeset amends the Soy view renderer, to support a new
interface called `ReactiveViewRenderer`. The new interface
generates a Flowable instead of a Writable, so that reactive
chunked responses can be generated when the renderer is
waiting on Future values to resolve.
@sgammon
Don't re-create HTTP response when rendering
2daa496
@sgammon
Add finalizeResponse interface to SoyContextMediator
2a68655
@sgammon
Add interface for MessageDigest from render
55268ec
@sgammon
Provide request to finalizeResponse
b7be919
@sdelamo
Merge branch 'main' into pullrequests/sgammon/soy/async-chunked-v2
d019e72
@sdelamo
reindent file with four spaces
1f8b178
@sdelamo
Merge branch 'main' into pullrequests/sgammon/soy/async-chunked-v2
0d92436 
# Conflicts:
#	views-soy/src/main/java/io/micronaut/views/soy/SoySauceViewsRenderer.java
@sdelamo
use micronaut nullability annotations
73a5bf8
@sdelamo
remove extra blank lines
deaceeb
@sdelamo
use parameterized logging
82780cf
@sdelamo
remove usage of Optional in fields and method parameters
8c07c44
@sdelamo
replace RxHttpClient with HttpClient
ac69f5d
@sdelamo
Merge branch 'main' into pullrequests/sgammon/soy/async-chunked-v2
1767cff
@sdelamo
Merge branch 'main' into pullrequests/sgammon/soy/async-chunked-v2
1f866e4
@sdelamo
changes to soy
e5011bb
@sdelamo sdelamo changed the title Pullrequests/sgammon/soy/async chunked v2 Reactive Views Renderer Soy Aug 10, 2021
@sdelamo sdelamo force-pushed the pullrequests/sgammon/soy/async-chunked-v2 branch 2 times, most recently from c49a73f to f78d45d Compare August 10, 2021 11:39
@sdelamo sdelamo force-pushed the pullrequests/sgammon/soy/async-chunked-v2 branch from f78d45d to e6d4728 Compare August 10, 2021 11:43
@sdelamo
Copy link
Contributor Author

sdelamo commented Aug 10, 2021

@sgammon I have taken your PR #34 updated to:

  • use Project Reactor instead of RxJava2
  • change the spacing to use 4 spaces instead of 2
  • use micronaut nullability annotations intead of javax annotations.

However, they are failing test. Not sure if you can check it out and let me know what am I missing?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ sdelamo
❌ sgammon
You have signed the CLA already but the status is still pending? Let us recheck it.

@sgammon
Copy link
Contributor

sgammon commented Feb 8, 2024

@sdelamo I never got notified about this. I'd be happy to take a look.

@sdelamo
Copy link
Contributor Author

sdelamo commented Feb 22, 2024 •
edited
Loading

@sgammon master has changed a lot since. We will need to merge master into this PR. If you want to do another effort towards this, I will review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdelamo @CLAassistant @sgammon