Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize #151

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Modernize #151

merged 6 commits into from
Sep 19, 2024

Conversation

dyollb
Copy link
Contributor

@dyollb dyollb commented Sep 14, 2024

move metadata from setup.py to pyproject.toml

  • package version is dynamically extracted from nrrd.__version__

upgrade pre-commit hooks

  • replace flake8 hook by https://github.com/PyCQA/flake8, which is "standard" (running the old hook was asking me for a gitlab password)
  • add typos hook (only found one typo, but doesn't cost much to run it)

Copy link
Collaborator

@addisonElliott addisonElliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks! One minor comment about adding link to docs.

pyproject.toml Show resolved Hide resolved
@addisonElliott addisonElliott merged commit 52e9e37 into mhe:master Sep 19, 2024
3 checks passed
addisonElliott added a commit that referenced this pull request Nov 7, 2024
* Incorrect README path causing issues with publishing
    * Introduced in #151.
* Point to `LICENSE` file
* Add myself to authors list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants