Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation in getDisplayName #606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qwIvan
Copy link

@qwIvan qwIvan commented Dec 22, 2015

All the language using lowercase id as the t9n key not displayname.
Current problem is the id like email, username will be capitalize to Email, Username, so will be translate failed.
https://github.com/softwarerero/meteor-accounts-t9n/blob/master/t9n/en.coffee
https://github.com/softwarerero/meteor-accounts-t9n/blob/master/t9n/zh_cn.coffee

@splendido
Copy link
Member

Correct!

but with your changes we're going to have a double look up in the T9n keys: see this line

Could you please try removing this second one and verify everythings work fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants