Added all in one makefile rule to deploy bundle images #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shruti2522 <[email protected]>
shruti2522
changed the title
fedepaol
reviewed
Apr 22, 2024
Makefile
Outdated
| @@ -179,6 +179,13 @@ deploy-with-olm: deploy-olm load-on-kind build-and-push-bundle-images ## deploys | |||
| $(KUSTOMIZE) build config/olm-install | kubectl apply -f - | |||
| VERSION=$(CSV_VERSION) NAMESPACE=$(NAMESPACE) hack/wait-for-csv.sh | |||
|
|
|||
| deploy-olm-real: export OPERATOR_SDK=operator-sdk | |||
| deploy-olm-real: deploy-olm build-and-push-bundle-images ## deploys the operator via OLM on a real cluster | |||
There was a problem hiding this comment.
We should remove the deploy-olm dependency?
Also, I wonder if we can refactor this a bit to avoid duplications with deploy-with-olm
Signed-off-by: shruti2522 <[email protected]>
fedepaol
reviewed
Apr 24, 2024
config/manager/kustomization.yaml
Outdated
| @@ -1,10 +1,10 @@ | |||
| resources: | |||
| - manager.yaml | |||
| - manager.yaml | |||
There was a problem hiding this comment.
this shouldn't be part of this commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #459
I've added
deploy-olm-realrule to the Makefile, making it easier to deploy the operator. Now, it handles tasks like building images, updating references, applying resources, and ensuring readiness, streamlining cluster management for smoother operation.