rewrite func getImageNameTag for supporting registries with port #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem198315
force-pushed
the
main
branch
3 times, most recently
from
43ce79d
to
ea891f6
Compare
oribon
reviewed
Aug 2, 2023
artem198315
force-pushed
the
main
branch
2 times, most recently
from
6f16388
to
bcbb39d
Compare
i added unit test |
|
can you rebase so that only your 2 commits show up, and add some message? we're trying to follow https://cbea.ms/git-commit, a short description suffices |
artem198315
force-pushed
the
main
branch
2 times, most recently
from
0cdf759
to
d4a049b
Compare
Please, check |
oribon
reviewed
Aug 3, 2023
artem198315
force-pushed
the
main
branch
2 times, most recently
from
e667a2b
to
418bfe4
Compare
|
Please, check |
|
@artem198315 sorry clicked the wrong button 😞, can you please rebase your local branch and push again? |
To make operator works with image's path in format: myregistry.local.com:5000/metallb/controller:v0.13.9 Signed-off-by: artem198315 <[email protected]>
Signed-off-by: artem198315 <[email protected]>
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make operator works with image's path in format myregistry.local.com:5000/metallb/controller:v0.13.9