Extend metrics #38
Merged
Extend metrics #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oribon
force-pushed
the
moremetrics
branch
3 times, most recently
from
e000e5a
to
93f5652
Compare
|
just align the helm charts too |
Changing the metrics port so this pod does not clash with MetalLB's HTTP port Signed-off-by: Ori Braunshtein <[email protected]>
Similarly to MetalLB we add some metrics regarding k8s updates. Also these register with the global controller-runtime metrics so we get some for free. Signed-off-by: Ori Braunshtein <[email protected]>
Signed-off-by: Ori Braunshtein <[email protected]>
Add a metric for the amount of prefixes received on a BGP session. Signed-off-by: Ori Braunshtein <[email protected]>
Signed-off-by: Ori Braunshtein <[email protected]>
Signed-off-by: Ori Braunshtein <[email protected]>
done |
fedepaol
reviewed
Sep 15, 2023
| @@ -188,7 +188,7 @@ spec: | |||
| args: | |||
| - "--node-name=$(NODE_NAME)" | |||
| - "--namespace=$(NAMESPACE)" | |||
| - "--metrics-bind-address=127.0.0.1:{{ .Values.prometheus.metricsPort }}" | |||
| - "--metrics-bind-address=:{{ .Values.prometheus.metricsPort }}" | |||
There was a problem hiding this comment.
I think binding to 127.0.0.1 is better than listening on any
There was a problem hiding this comment.
I changed it here so it is aligned with the regular manifests and the code's default (when we generated the controller), do you think we should change it everywhere?
There was a problem hiding this comment.
yeah I think this is better as the pod is hostnetworked adn we won't expose the port outside.
Since the pods are host-networked we should restrict the HTTP metrics endpoints to lo, allowing access from outside only to the HTTPs kube-rbac-proxy endpoints. Signed-off-by: Ori Braunshtein <[email protected]>
Now that the HTTP metrics endpoints listen only on lo we need to access them through the rbac-proxy endpoint when coming from outside (from the prometheus pod). Signed-off-by: Ori Braunshtein <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #33
this aligns the ports to not clash with MetalLB and adds some metrics