FRR-K8s: make listening to incoming connections configurable #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karampok
reviewed
Nov 21, 2024
charts/frr-k8s/values.yaml
Outdated
| @@ -163,6 +163,8 @@ frrk8s: | |||
| metricsPort: 7573 | |||
| resources: {} | |||
| secureMetricsPort: 9141 | |||
| # frr contains configuration specific to the FRR container, | |||
There was a problem hiding this comment.
I do not understand the comment, can you expand?
There was a problem hiding this comment.
because it's a copy / paste mistake :D
re: metallb: it depends. If it uses kustomize, it will need to provide a custom configmap / kustomize override it. With helm, it uses helm. The operator uses helm |
In case full mesh is not needed, always connecting results in a more predictable behavior. Signed-off-by: Federico Paolinelli <[email protected]>
fedepaol
force-pushed
the
configurablelisten
branch
from
c2bb74b
to
46dcc92
Compare
karampok
approved these changes
Nov 21, 2024
|
CI failed in GR test and logs and It looks again that route-map was and the BGPD crashed (because pid was not found). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a BUG FIX or a FEATURE ?:
What this PR does / why we need it:
In case full mesh is not needed, always connecting results in a more predictable behavior. So let's let the user choose if they want to accept connectoins or not.
Special notes for your reviewer:
Release note: