Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump prow tests to Go 1.23 #909

Merged
merged 1 commit into from
Nov 23, 2024
Merged

bump prow tests to Go 1.23 #909

merged 1 commit into from
Nov 23, 2024
+25 −25

Conversation

tuminoid
Copy link
Member

Bump prow tests go use golang:1.23 and basic-checks:1.23, as now Golang bumps are completed.

@tuminoid
bump prow tests to Go 1.23
4e0b00d 
Bump prow tests go use golang:1.23 and basic-checks:1.23, as now
Golang bumps are completed.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid
Copy link
Member Author

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 22, 2024
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member Author

/cc @lentzi90 @kashifest

lentzi90
lentzi90 reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
❤️ the new config structure! It makes it so easy to tell what repos and branches are involved

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2024
@tuminoid
Copy link
Member Author

/approve ❤️ the new config structure! It makes it so easy to tell what repos and branches are involved

Yes, indeed. Thanks for making it happen!

Sunnatillo
Sunnatillo approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sunnatillo,lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit dcceda7 into metal3-io:main Nov 23, 2024
5 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/bump-checks-to-go-1.23 branch November 23, 2024 00:16
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key baremetal-operator-release-0.8.yaml using file prow/config/jobs/metal3-io/baremetal-operator-release-0.8.yaml
  • key baremetal-operator.yaml using file prow/config/jobs/metal3-io/baremetal-operator.yaml
  • key cluster-api-provider-metal3.yaml using file prow/config/jobs/metal3-io/cluster-api-provider-metal3.yaml
  • key cluster-api-provier-metal3-release-1.8.yaml using file prow/config/jobs/metal3-io/cluster-api-provier-metal3-release-1.8.yaml
  • key ip-address-manager-release-1.8.yaml using file prow/config/jobs/metal3-io/ip-address-manager-release-1.8.yaml
  • key ip-address-manager.yaml using file prow/config/jobs/metal3-io/ip-address-manager.yaml
  • key ironic-standalone-operator.yaml using file prow/config/jobs/metal3-io/ironic-standalone-operator.yaml

In response to this:

Bump prow tests go use golang:1.23 and basic-checks:1.23, as now Golang bumps are completed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@Sunnatillo Sunnatillo Sunnatillo approved these changes

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @metal3-io-bot @lentzi90 @Sunnatillo