Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Fixing agent creation timeout issue #905

Merged
merged 1 commit into from
Nov 19, 2024
Merged

🌱 Fixing agent creation timeout issue #905

merged 1 commit into from
Nov 19, 2024

Conversation

adilGhaffarDev
Copy link
Member

This PR moves agent creation outside the stage, ensuring it doesn't time out. This change reduces timeout failures in tests, especially when the infrastructure is slow. Additionally, it aligns the agent creation process with other pipeline scripts for consistency.

@adilGhaffarDev
Fixing agent creation timeout issue
21c4e16 
Signed-off-by: Muhammad Adil Ghaffar <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 19, 2024
Sunnatillo
Sunnatillo reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
tuminoid
tuminoid reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024
@tuminoid
Copy link
Member

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot merged commit 1a5cd6a into metal3-io:main Nov 19, 2024
5 checks passed
@metal3-io-bot metal3-io-bot deleted the fixing-timeouts/adil branch November 19, 2024 12:15
@Sunnatillo
Copy link
Member

/override metal3-ubuntu-e2e-integration-test-main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@tuminoid tuminoid tuminoid left review comments

@Rozzii Rozzii Awaiting requested review from Rozzii

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adilGhaffarDev @metal3-io-bot @tuminoid @Sunnatillo