Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prow: Fix milestone applier config #897

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Prow: Fix milestone applier config #897

merged 1 commit into from
Nov 8, 2024

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Nov 8, 2024

Now it should match the actual milestones.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 8, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Nov 8, 2024

/cc @Rozzii @tuminoid
/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main

In response to this:

/cc @Rozzii @tuminoid
/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Rozzii
Rozzii reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@Rozzii Rozzii removed the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@Rozzii
Copy link
Member

Rozzii commented Nov 8, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
tuminoid
tuminoid reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue, plus older milestones still need renaming.

/hold
until they're consistently named.

But generally, this is what we agreed, so
/approve

prow/config/plugins.yaml Outdated
release-0.5: v0.5
main: "BMO - v0.9"
release-0.8: "BMO - v0.8"
release-0.7: "BMO - v0.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no BMO 0.7

Copy link
Member

@Rozzii Rozzii Nov 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was an issue during release there is a comment on the milestone

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm but we have a branch and milestone. Should we remove it from here because we don't expect to use it or do we just keep it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not have milestone, and branch is locked, so it should not be mentioned anywhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I will remove it from here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have only branch no milestone but yes IMO we can get rid of that 0,7 branch.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
@lentzi90 lentzi90 force-pushed the lentzi90/fix-milestone-config branch from 60ab57b to 483ddca Compare November 8, 2024 12:07
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Nov 8, 2024

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Rozzii
Rozzii reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@Rozzii
Copy link
Member

Rozzii commented Nov 8, 2024

It think this is good to go now.

@lentzi90
Copy link
Member Author

lentzi90 commented Nov 8, 2024

Thanks @Rozzii !
/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@metal3-io-bot metal3-io-bot merged commit c7bc97d into metal3-io:main Nov 8, 2024
5 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/fix-milestone-config branch November 8, 2024 12:12
@metal3-io-bot
Copy link
Collaborator

@lentzi90: Updated the plugins configmap in namespace prow at cluster default using the following files:

  • key plugins.yaml using file prow/config/plugins.yaml

In response to this:

Now it should match the actual milestones.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii left review comments

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lentzi90 @metal3-io-bot @Rozzii @tuminoid