Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update key generation #277

Merged
merged 21 commits into from
Sep 8, 2024
Merged

Conversation

KomelT
Copy link
Contributor

@KomelT KomelT commented Aug 23, 2024

@Hunter275
Copy link
Member

Hunter275 commented Aug 24, 2024

@KomelT

We shouldn't need to generate the Admin Key, it will be the key of another device.

We should also add a confirmation dialog for generating a new Private Key.

I will add these to #272

@KomelT
Copy link
Contributor Author

KomelT commented Aug 24, 2024

@Hunter275 yes you are right, I miss-read the comment. Thanks.

@jp-bennett
Copy link

jp-bennett commented Sep 2, 2024

Key generation seems to be working as expected now. There are a couple little issues I've seen. First, having legacy admin enabled actually disables the private key field, where it should be disabling the admin key. (Though technically both can be turned on if somebody really wanted to).

Next, I don't understand the submit button, as none of the other fields have this. It does seem to be required to get settings to stick, to hit submit first, then the save icon.

And finally, if a user pasts a private key in to the field, this should blank out the public key, so the firmware will regenerate the appropriate key. Nevermind, the web app correctly regenerates the public key, and I didn't notice. 0=)

@Hunter275 Hunter275 added enhancement New feature or request major change This is a major change parity Feature is in other app (iOS, Android, etc) labels Sep 5, 2024
@Hunter275 Hunter275 merged commit 2e12b27 into meshtastic:pki Sep 8, 2024
3 checks passed
@KomelT KomelT deleted the feature/security-tab branch September 9, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major change This is a major change parity Feature is in other app (iOS, Android, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants