Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix references counting for remote publisher and streams (see #3359) #3475

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Fix references counting for remote publisher and streams (see #3359) #3475

merged 3 commits into from
Nov 12, 2024

Conversation

atoppi
Copy link
Member

@atoppi atoppi commented Nov 6, 2024

This PR tries to solve the issues described in #3359.
It's a bit more convoluted than the original patch since it addresses also some error cases.

@atoppi atoppi mentioned this pull request Nov 6, 2024
Closed
@fancycode
Copy link
Contributor

LGTM as commented in #3359 (comment)

@spscream spscream mentioned this pull request Nov 7, 2024
Closed
@lminiero
Copy link
Member

Merging.

@lminiero lminiero merged commit c917ee6 into master Nov 12, 2024
8 checks passed
@lminiero lminiero deleted the fix/1x-vr-remote-publisher-references branch November 12, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fancycode fancycode fancycode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atoppi @fancycode @lminiero