autogen.sh: prefer shallow git submodules if parent is shallow #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most likely scenario for someone to use a shallow clone is to save some bandwidth (especially useful for slow or data-capped connections), so it makes sense to assume that the submodules should be retreived in a similar way (especially considering some submodules that Smuxi depends on are quite heavy, possibly due to inclusion of binaries).
|
Since this build flavor isn't covered in the CI, does this really build? smuxi has a submodule lib/SmartIrc4net and that has a submodule src/starksoftproxy so depth would be 2 instead of 1 |
Mmm, depth is not the submodule nesting depth but the amount of commits back in history you want to retreive. But anyway, true, I see that the submodule population is somehow not working: But the one that failed is agsxmpp, not SmartIrc4net :-m |
|
If I try again, I get: I've read about this error, and it seems it's because the repositories of the submodules are not pointing to the last HEAD (which is normal), and git > 2.8 might have better support for this (unfortunately this version is too bleeding edge for most distros I guess, since the last ubuntu LTS bundles 2.7.4). I guess we can wait a bit until we can merge this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most likely scenario for someone to use a shallow
clone is to save some bandwidth (especially useful for
slow or data-capped connections), so it makes sense to
assume that the submodules should be retreived in a
similar way (especially considering some submodules
that Smuxi depends on are quite heavy, possibly due to
inclusion of binaries).