Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add common redirects to v1 docs #9832

Merged
merged 2 commits into from
Nov 10, 2024
Merged

docs: add common redirects to v1 docs #9832

merged 2 commits into from
Nov 10, 2024

Conversation

shahednasser
Copy link
Member

Add common redirects to v1 docs that don't affect v2 docs

@shahednasser shahednasser requested a review from a team as a code owner October 28, 2024 04:32
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 2:28pm
api-reference-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 2:28pm
docs-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 2:28pm
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 2:28pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 2:28pm
resources-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 2:28pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 2:28pm

Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: 7598e79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -157,6 +157,21 @@ const nextConfig = {
destination: "/:path*",
permanent: true,
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Any reason we shouldn't redirect to the v2 docs here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Fixed

@kodiakhq kodiakhq bot merged commit d0d9bbc into develop Nov 10, 2024
32 checks passed
@kodiakhq kodiakhq bot deleted the docs/v1-redirects branch November 10, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants