Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid mutation for product media gallery #9371

Merged

Conversation

joekendal
Copy link
Contributor

On Version 2, the admin dashboard has an error

This PR fixes the following error on the product media gallery:

{type: "invalid_data",…}
message
: 
"Invalid request: Expected type: 'object' for field 'images, 0', got: 'string'"
type
: 
"invalid_data"

Steps to reproduce:

  1. use the preview
  2. navigate to a product with multiple images
  3. don't click on edit. just click on an image
  4. click on the trash icon
  5. see error in terminal and browser console/network tab

Copy link

changeset-bot bot commented Sep 29, 2024

⚠️ No Changeset found

Latest commit: a9f5219

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 29, 2024

@joekendal is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@sradevski
Copy link
Member

Thanks, we'll have it merged soon!

@sradevski sradevski merged commit 6fbfbfa into medusajs:develop Sep 30, 2024
14 of 22 checks passed
riqwan pushed a commit that referenced this pull request Oct 4, 2024
panalgin pushed a commit to vennyx-org/medusa that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants