Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): location UI fixes #7288

Merged
merged 8 commits into from
May 16, 2024
Merged

fix(dashboard): location UI fixes #7288

merged 8 commits into from
May 16, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented May 10, 2024 •
edited
Loading

WHAT

  • add "Edit service zone areas" view
  • add "Shipping option pricing edit" view
  • a few other UI fixes

@vercel Vercel
Copy link

vercel bot commented May 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 8:52am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) May 14, 2024 8:52am
docs-ui ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 8:52am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 8:52am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 53ede0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fPolic fPolic marked this pull request as ready for review May 13, 2024 13:18
@fPolic fPolic requested a review from a team as a code owner May 13, 2024 13:18
@fPolic fPolic requested review from sradevski, riqwan, olivermrbl and kasperkristensen and removed request for sradevski and riqwan May 13, 2024 13:18
olivermrbl
olivermrbl reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flows are working as expected. I will @kasperkristensen to look through the UI changes.

Have you ensured that types are correct with respect to Kasper's recent comments?

...g/service-zone-areas-edit/components/edit-region-areas-form/edit-service-zone-areas-form.tsx Show resolved Hide resolved
...g/service-zone-areas-edit/components/edit-region-areas-form/edit-service-zone-areas-form.tsx Outdated Show resolved Hide resolved
...hipping/service-zone-create/components/create-service-zone-form/create-service-zone-form.tsx Outdated Show resolved Hide resolved
@olivermrbl olivermrbl merged commit 694434d into develop May 16, 2024
17 checks passed
@olivermrbl olivermrbl deleted the fix/location-ui-fixes branch May 16, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fPolic @olivermrbl