Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMO handling the new Exclude From remediation label on the node #105

Conversation

mshitrit
Copy link
Member

@mshitrit mshitrit commented Dec 4, 2023

ECOPROJECT-1747 , ECOPROJECT-1779, ECOPROJECT-1785

Supporting snr feature, making sure that once a node is put into maintenance by NMO it will apply the label which will cause SNR to stop running on that node.
This functionality is required for use cases where we would like to disable SNR (for example Node maintenance).

Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 4, 2023
@mshitrit
Copy link
Member Author

mshitrit commented Dec 4, 2023

/test ?

Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

@mshitrit: The following commands are available to trigger required jobs:

  • /test 4.12-ci-index
  • /test 4.12-images
  • /test 4.12-openshift-e2e
  • /test 4.13-ci-index
  • /test 4.13-images
  • /test 4.13-openshift-e2e
  • /test 4.14-ci-index
  • /test 4.14-images
  • /test 4.14-openshift-e2e
  • /test 4.15-ci-index
  • /test 4.15-images
  • /test 4.15-openshift-e2e

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mshitrit
Copy link
Member Author

mshitrit commented Dec 4, 2023

/test 4.13-openshift-e2e

controllers/nodemaintenance_controller.go Outdated Show resolved Hide resolved
Signed-off-by: Michael Shitrit <[email protected]>

Signed-off-by: Michael Shitrit <[email protected]>
@mshitrit
Copy link
Member Author

mshitrit commented Dec 5, 2023

/test 4.13-openshift-e2e

@mshitrit mshitrit changed the title [WIP] NMO handling the new Exclude From remediation label on the node NMO handling the new Exclude From remediation label on the node Dec 5, 2023
@slintes
Copy link
Member

slintes commented Dec 5, 2023

/lgtm

@slintes slintes marked this pull request as ready for review December 5, 2023 08:24
@openshift-ci openshift-ci bot requested review from razo7 and slintes December 5, 2023 08:24
@mshitrit
Copy link
Member Author

mshitrit commented Dec 5, 2023

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 137cff3 into medik8s:main Dec 5, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants