Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Two Reasons for Updating and Stopping Remediation #76

Merged

Commits on Aug 14, 2023

  1. Add two reasons for updating and stoping remediation

    When either FAR CR name doesn't match a node name or Node Healthcheck timeout annotation has been set we update the CR three conditions to false
    razo7 committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    9126ce4 View commit details
    Browse the repository at this point in the history
  2. Don't stop update of condition from false to true

    It is not necessary
    razo7 committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    8005d8a View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Better reason for NHC annotation signal

    RemediationStoppedByNHC -> RemediationInterruptedByNHC. NHC is signalling a timeout that interrupts the remediation and it does not stopping/terminating a remediation. FAR does that when it notice the annotation.
    razo7 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    6f62b11 View commit details
    Browse the repository at this point in the history
  2. Separate condition message for RemediationFinishedNodeNotFound and Re…

    …mediationInterruptedByNHC
    
    Clearer message for the users
    razo7 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    01241d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Switch case usage for conditionMessage of a failure

    It helps us forgetting this part when adding another reason to the case statement above.
    razo7 committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c0e69f2 View commit details
    Browse the repository at this point in the history