-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#1360): Document how to configure Android App Link verification #1366
Conversation
@jkuester @sugat009 could you take a look at the docs for setting up medic/cht-android#308 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and detailed! I left a few comments about content and structuring of the docs within the site, but here is my overall vision:
- General overview of deep linking functionality (especially from a user's perspective) should go in
features/integrations/android
- The technical instructions for how to create your
assetlinks.json
file and how to verify that deep links work with your app/instance should go inguides/android
(either in a new page or as a section ofguides/android/branding
. - An overview of the
assetlinks.json
file structure, its location and usage in the config should go inreference/app-settings/assetlinks
.
With the right linkage connecting everything I think this would communicate the right things to the right people in the right places. (Open to other ideas here though!)
I have been working on testing these steps locally, but ran out of time today and did not want to block the rest of this review. I will leave another comment tomorrow regarding how my tests went!
Just following up to say I was successfully in getting this process to work end-to-end, starting from scratch with a new Android flavor by following this documentation! In particular, the verification instructions were very handy when I typoed my package name and was trying to debug what was going wrong! All in all, this is a tricky process, but this documentation is solid and makes it very straight forward to get things setup! |
Co-authored-by: Joshua Kuestersteffen <[email protected]>
Co-authored-by: Joshua Kuestersteffen <[email protected]>
Co-authored-by: Joshua Kuestersteffen <[email protected]>
Co-authored-by: Joshua Kuestersteffen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Had a few minor thoughts that I left inline, but all in all we have some solid documentation here!
Co-authored-by: Joshua Kuestersteffen <[email protected]>
Co-authored-by: Joshua Kuestersteffen <[email protected]>
Description
#1360
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.